Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Numpy changed longdouble str representations in 1.18 #858

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Jan 7, 2020

numpy/numpy#10151 broke the h5py compatibility tests which checked for string matching.

That wasn't an important test, but it did explain why the issue took so long to track down. This update adds numpy 1.18's changes to the logic.

All of this will go away when we drop Python 3.5.

@effigies effigies added this to the 3.0.1 milestone Jan 7, 2020
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #858 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
- Coverage   90.07%   89.87%   -0.21%     
==========================================
  Files          96       96              
  Lines       12392    12392              
  Branches     2186     2186              
==========================================
- Hits        11162    11137      -25     
- Misses        881      906      +25     
  Partials      349      349
Impacted Files Coverage Δ
nibabel/keywordonly.py 92.85% <0%> (-7.15%) ⬇️
nibabel/nicom/dicomwrappers.py 85.16% <0%> (-5.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a66c0b2...fadfb45. Read the comment docs.

@skoudoro
Copy link
Member

skoudoro commented Jan 7, 2020

By curiosity, when do you plan do drop python3.5?

@effigies
Copy link
Member Author

effigies commented Jan 7, 2020

By curiosity, when do you plan do drop python3.5?

First minor release after March 14, 2020: #803

@skoudoro
Copy link
Member

skoudoro commented Jan 7, 2020

Thank you for this info and the pointer to #803

@effigies
Copy link
Member Author

effigies commented Jan 7, 2020

Failed test to be resolved in #857.

@effigies effigies merged commit 2dccadf into nipy:master Jan 7, 2020
@effigies effigies deleted the fix/h5py_numpy_hack branch January 7, 2020 19:22
@effigies
Copy link
Member Author

effigies commented Jan 7, 2020

Merged into master, not maint/3.0.x. Cherry-picked into maint/3.0.x in 50abcb3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants