Fix bug where AsyncioRunnable hangs if process_one throws and the source is not emitting new values
#523
Codecov / codecov/project
succeeded
Jan 7, 2025 in 0s
74.00% (+19.65%) compared to 7d5e48f
View this Pull Request on Codecov
74.00% (+19.65%) compared to 7d5e48f
Details
Codecov Report
Attention: Patch coverage is 19.23077% with 42 lines in your changes missing coverage. Please review.
Project coverage is 74.00%. Comparing base (
7d5e48f) to head (467c07b).
Additional details and impacted files
@@ Coverage Diff @@
## branch-25.02 #523 +/- ##
=================================================
+ Coverage 54.34% 74.00% +19.65%
=================================================
Files 372 407 +35
Lines 12553 15101 +2548
Branches 1104 1198 +94
=================================================
+ Hits 6822 11175 +4353
+ Misses 5731 3926 -1805 | Files with missing lines | Coverage Δ | |
|---|---|---|
| cpp/mrc/include/mrc/edge/edge_channel.hpp | 86.36% <100.00%> (+1.36%) |
⬆️ |
| ...thon/mrc/_pymrc/include/pymrc/asyncio_runnable.hpp | 95.58% <100.00%> (+0.35%) |
⬆️ |
| cpp/mrc/include/mrc/node/sink_properties.hpp | 72.72% <0.00%> (-4.70%) |
⬇️ |
| cpp/mrc/include/mrc/node/source_properties.hpp | 49.25% <0.00%> (-1.52%) |
⬇️ |
| cpp/mrc/include/mrc/edge/edge_readable.hpp | 62.22% <0.00%> (-22.63%) |
⬇️ |
| python/mrc/_pymrc/include/pymrc/node.hpp | 40.00% <0.00%> (-21.23%) |
⬇️ |
... and 168 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 7d5e48f...467c07b. Read the comment docs.
Loading