Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where AsyncioRunnable hangs if process_one throws and the source is not emitting new values #523

Open
wants to merge 9 commits into
base: branch-25.02
Choose a base branch
from

Merge branch 'branch-25.02' of github.com:nv-morpheus/MRC into david-…

467c07b
Select commit
Loading
Failed to load commit list.
Open

Fix bug where AsyncioRunnable hangs if process_one throws and the source is not emitting new values #523

Merge branch 'branch-25.02' of github.com:nv-morpheus/MRC into david-…
467c07b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 7, 2025 in 1s

19.23% of diff hit (target 54.34%)

View this Pull Request on Codecov

19.23% of diff hit (target 54.34%)

Annotations

Check warning on line 116 in cpp/mrc/include/mrc/edge/edge_readable.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/edge/edge_readable.hpp#L116 

Added line #L116 was not covered by tests

Check warning on line 119 in cpp/mrc/include/mrc/edge/edge_readable.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/edge/edge_readable.hpp#L118-L119 

Added lines #L118 - L119 were not covered by tests

Check warning on line 121 in cpp/mrc/include/mrc/edge/edge_readable.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/edge/edge_readable.hpp#L121 

Added line #L121 was not covered by tests

Check warning on line 124 in cpp/mrc/include/mrc/edge/edge_readable.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/edge/edge_readable.hpp#L124 

Added line #L124 was not covered by tests

Check warning on line 127 in cpp/mrc/include/mrc/edge/edge_readable.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/edge/edge_readable.hpp#L127 

Added line #L127 was not covered by tests

Check warning on line 156 in cpp/mrc/include/mrc/edge/edge_readable.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/edge/edge_readable.hpp#L156 

Added line #L156 was not covered by tests

Check warning on line 159 in cpp/mrc/include/mrc/edge/edge_readable.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/edge/edge_readable.hpp#L158-L159 

Added lines #L158 - L159 were not covered by tests

Check warning on line 161 in cpp/mrc/include/mrc/edge/edge_readable.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/edge/edge_readable.hpp#L161 

Added line #L161 was not covered by tests

Check warning on line 164 in cpp/mrc/include/mrc/edge/edge_readable.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/edge/edge_readable.hpp#L164 

Added line #L164 was not covered by tests

Check warning on line 167 in cpp/mrc/include/mrc/edge/edge_readable.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/edge/edge_readable.hpp#L167 

Added line #L167 was not covered by tests

Check warning on line 47 in cpp/mrc/include/mrc/node/sink_properties.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/node/sink_properties.hpp#L47 

Added line #L47 was not covered by tests

Check warning on line 49 in cpp/mrc/include/mrc/node/sink_properties.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/node/sink_properties.hpp#L49 

Added line #L49 was not covered by tests

Check warning on line 291 in cpp/mrc/include/mrc/node/source_properties.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/node/source_properties.hpp#L291 

Added line #L291 was not covered by tests

Check warning on line 293 in cpp/mrc/include/mrc/node/source_properties.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/include/mrc/node/source_properties.hpp#L293 

Added line #L293 was not covered by tests

Check warning on line 198 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L198 

Added line #L198 was not covered by tests

Check warning on line 201 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L200-L201 

Added lines #L200 - L201 were not covered by tests

Check warning on line 203 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L203 

Added line #L203 was not covered by tests

Check warning on line 209 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L209 

Added line #L209 was not covered by tests

Check warning on line 211 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L211 

Added line #L211 was not covered by tests

Check warning on line 214 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L214 

Added line #L214 was not covered by tests

Check warning on line 246 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L246 

Added line #L246 was not covered by tests

Check warning on line 249 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L248-L249 

Added lines #L248 - L249 were not covered by tests

Check warning on line 251 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L251 

Added line #L251 was not covered by tests

Check warning on line 253 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L253 

Added line #L253 was not covered by tests

Check warning on line 255 in python/mrc/_pymrc/include/pymrc/node.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/include/pymrc/node.hpp#L255 

Added line #L255 was not covered by tests
View more details on Codecov