[Breaking change] Add conversions from proto to core types

[pronebird]

1. Add From conversions from proto to TunnelState
2. Simplify types used in TunnelState by converting some of the nym types into String
3. nym-lib-types: Add feature gate nym-type-conversions to remove dependendencies on nym crates when not needed.
4. Drop some of the old types and return TunnelState from grpc which is a breaking change and it will break desktop apps.
5. nym-vpnc: Leverage From conversions instead of working with raw grpc types when reporting vpn status.

---

This change is 

[octol]

Reviewable status: 0 of 24 files reviewed, 2 unresolved discussions (waiting on @doums, @neacsu, @pronebird, @rokas-ambrazevicius, and @zaneschepke)

---

nym-vpn-core/crates/nym-vpn-lib-types/src/connection_data.rs line 14 at r1 (raw file):

pub struct ConnectionData {
    /// Mixnet entry gateway identity encoded as base58 string.
    pub entry_gateway: String,

I kinda think we should have strong types for identity and address, even if it's just a thin wrapper around their base58 string representations. I've observed these types being easy to mix up for newcomers to the code base

[pronebird]

Reviewable status: 0 of 25 files reviewed, 1 unresolved discussion (waiting on @doums, @neacsu, @octol, @rokas-ambrazevicius, and @zaneschepke)

---

nym-vpn-core/crates/nym-vpn-lib-types/src/connection_data.rs line 14 at r1 (raw file):

Previously, octol (Jon Häggblad) wrote…

I kinda think we should have strong types for identity and address, even if it's just a thin wrapper around their base58 string representations. I've observed these types being easy to mix up for newcomers to the code base

Added Gateway and NymAddress wrapper types.

[octol]

Reviewable status: 0 of 25 files reviewed, 1 unresolved discussion (waiting on @neacsu, @pronebird, @rokas-ambrazevicius, and @zaneschepke)

---

nym-vpn-core/crates/nym-vpn-lib-types/src/connection_data.rs line 86 at r4 (raw file):

        Self::new(value.gateway().to_base58_string())
    }
}

I like this, it establishes a compile time link between the types and what the string represents

[octol]

Reviewed 17 of 24 files at r1, 1 of 1 files at r2, 2 of 7 files at r3, 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @neacsu, @pronebird, @rokas-ambrazevicius, and @zaneschepke)

[octol]

Reviewable status: 25 of 26 files reviewed, 2 unresolved discussions (waiting on @doums, @neacsu, @pronebird, @rokas-ambrazevicius, and @zaneschepke)

---

nym-vpn-core/crates/nym-vpn-lib-types/src/connection_data.rs line 84 at r4 (raw file):

impl From<nym_gateway_directory::Recipient> for NymAddress {
    fn from(value: nym_gateway_directory::Recipient) -> Self {
        Self::new(value.gateway().to_base58_string())

This here gives you the gateway identity sub-part of the nym-address, not the nym-address itself

[octol]

Reviewable status: 24 of 26 files reviewed, 1 unresolved discussion (waiting on @doums, @neacsu, @pronebird, @rokas-ambrazevicius, and @zaneschepke)

---

nym-vpn-core/crates/nym-vpn-lib-types/src/connection_data.rs line 84 at r4 (raw file):

Previously, octol (Jon Häggblad) wrote…

This here gives you the gateway identity sub-part of the nym-address, not the nym-address itself

Looking good!

[pronebird]

Dismissed @doums from a discussion.
Reviewable status: 24 of 26 files reviewed, all discussions resolved (waiting on @doums, @neacsu, @octol, @rokas-ambrazevicius, and @zaneschepke)

[pronebird]

Addressed all concerns.

[octol]

Reviewed 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @doums, @neacsu, @rokas-ambrazevicius, and @zaneschepke)