[FIX] charts: Account for correct locale when filtering empty datasets #5447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LucasLefevre
reviewed
Jan 9, 2025
Comment on lines
362
to
364
| B2: { content: "10.1" }, | ||
| B3: { content: "11.1" }, | ||
| B4: { content: "12.1" }, |
There was a problem hiding this comment.
one data point would be enough
The filtering of empty datasets did not use the correct locale to evaluate the nature of a dataset value. Since it evaluates the actual stored data, it is based on the default locale (i.e. a dot as a decimal separator). Task: 4465324
rrahir
force-pushed
the
18.0-fix-dataset-with-float-in-locale-rar
branch
from
b100699 to
c1ee986
Compare
This was referenced Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filtering of empty datasets did not use the correct locale to evaluate the nature of a dataset value. Since it evaluates the actual stored data, it is based on the default locale (i.e. a dot as a decimal separator).
Task: 4465324
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist