Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43610,CONSOLE-4434: update login page to PF6 and add validation #751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Jan 13, 2025

Related PR: openshift/oauth-templates#43 openshift/oauth-server#169 openshift/console#14621

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS, this reduces bits sent through the wire by ~26%
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

@logonoff logonoff changed the title feat(branding-secret): update login page to PF6 CONSOLE-4381: update login page to PF6 Jan 13, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2025

@logonoff: This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Related PR: openshift/oauth-templates#43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ibihim and liouk January 13, 2025 16:03
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2025

@logonoff: This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Related PR: openshift/oauth-templates#43

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff changed the title CONSOLE-4381: update login page to PF6 OCPBUGS-43610,CONSOLE-4381: update login page to PF6 Jan 13, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2025

@logonoff: This pull request references Jira Issue OCPBUGS-43610, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Related PR: openshift/oauth-templates#43

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff changed the title OCPBUGS-43610,CONSOLE-4381: update login page to PF6 OCPBUGS-43610,CONSOLE-4381: update login page to PF6 and add validation Jan 13, 2025
@logonoff
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2025

@logonoff: This pull request references Jira Issue OCPBUGS-43610, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

/hold

should ideally only be merged alongside openshift/console#14621

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2025

@logonoff: This pull request references Jira Issue OCPBUGS-43610, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Related PR: openshift/oauth-templates#43 openshift/oauth-server#169 openshift/console#14621

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2025

@logonoff: This pull request references Jira Issue OCPBUGS-43610, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Related PR: openshift/oauth-templates#43 openshift/oauth-server#169 openshift/console#14621

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
    Minified HTML output and removed unused CSS, this reduces bits sent through the wire by ~26%
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff changed the title OCPBUGS-43610,CONSOLE-4381: update login page to PF6 and add validation OCPBUGS-43610,CONSOLE-4434: update login page to PF6 and add validation Jan 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 14, 2025

@logonoff: This pull request references Jira Issue OCPBUGS-43610, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CONSOLE-4434 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Related PR: openshift/oauth-templates#43 openshift/oauth-server#169 openshift/console#14621

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS, this reduces bits sent through the wire by ~26%
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

@logonoff: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic 6f3f52d link true /test e2e-agnostic
ci/prow/e2e-console-login 6f3f52d link true /test e2e-console-login
ci/prow/test-operator-integration 6f3f52d link false /test test-operator-integration
ci/prow/e2e-operator 6f3f52d link true /test e2e-operator
ci/prow/e2e-agnostic-upgrade 6f3f52d link true /test e2e-agnostic-upgrade
ci/prow/e2e-agnostic-ipv6 6f3f52d link false /test e2e-agnostic-ipv6
ci/prow/okd-scos-e2e-aws-ovn 6f3f52d link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants