Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43610,CONSOLE-4434: Update to PF6 and add validation #43

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

OCPBUGS-43610,CONSOLE-4434: Update to PF6 and add validation #43

wants to merge 13 commits into from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Jan 10, 2025 •
edited
Loading

Related PRs: openshift/cluster-authentication-operator#751 openshift/oauth-server#169 openshift/console#14621

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS, this reduces bits sent through the wire by ~26%
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

@logonoff
chore(deps): update jekyll and remove github-pages
79a7cb9 
we aren't using any of the features provided by the GH pages gem, so remove it
@logonoff
feat: minify html output
a47b927
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 10, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the master branch 6 times, most recently from c2ce8b0 to 3ec3765 Compare January 10, 2025 21:26
@logonoff logonoff force-pushed the master branch 4 times, most recently from 31d5166 to 13489c4 Compare January 10, 2025 23:01
@logonoff
feat: install PatternFly 6, optimize CSS
91852ab 
Use PurgeCSS to remove unused CSS and update README to reflect the change

a
@logonoff
feat: add light mode
235010d 
also refactor layout further into a `base.html` for login providers and error
@logonoff
fix: make logo a bit smaller when <= 1200px
43b13e1 
also refactor generate-styles and further reduce build size
@logonoff logonoff force-pushed the master branch 2 times, most recently from 8d657d1 to 92027b5 Compare January 12, 2025 20:38
rhamilto
rhamilto reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, @logonoff. Fantastic work. A couple minor nits.

index.html Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rhamilto
Copy link
Member

/lgtm

But will hold until the console is converted to PF6.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
This was referenced Jan 13, 2025
Open
Open
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Related PRs: openshift/cluster-authentication-operator#751 openshift/oauth-server#169

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Related PRs: openshift/cluster-authentication-operator#751 openshift/oauth-server#169

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff changed the title CONSOLE-4381: Update to PF6 OCPBUGS-43610,CONSOLE-4381: Update to PF6 Jan 13, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references Jira Issue OCPBUGS-43610, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Related PRs: openshift/cluster-authentication-operator#751 openshift/oauth-server#169

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff changed the title OCPBUGS-43610,CONSOLE-4381: Update to PF6 OCPBUGS-43610,CONSOLE-4381: Update to PF6 and add validation Jan 13, 2025
@logonoff
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references Jira Issue OCPBUGS-43610, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references Jira Issue OCPBUGS-43610, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Related PRs: openshift/cluster-authentication-operator#751 openshift/oauth-server#169 openshift/console#14621

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references Jira Issue OCPBUGS-43610, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

This pull request references CONSOLE-4381 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Related PRs: openshift/cluster-authentication-operator#751 openshift/oauth-server#169 openshift/console#14621

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS, this reduces bits sent through the wire by ~26%
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto
rhamilto reviewed Jan 14, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
@logonoff logonoff force-pushed the master branch 2 times, most recently from f09aefd to 3dcc335 Compare January 14, 2025 14:24
@rhamilto
Copy link
Member

/lgtm

But will hold until openshift/console#14621 merges.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@logonoff logonoff changed the title OCPBUGS-43610,CONSOLE-4381: Update to PF6 and add validation OCPBUGS-43610,CONSOLE-4434: Update to PF6 and add validation Jan 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references Jira Issue OCPBUGS-43610, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CONSOLE-4434 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Related PRs: openshift/cluster-authentication-operator#751 openshift/oauth-server#169 openshift/console#14621

Brief description of changes:

  • Updated templates to use PF6
  • Update Red Hat font to 4.0.3
  • Minified HTML output and removed unused CSS, this reduces bits sent through the wire by ~26%
  • Disabled login button after "log in" is pressed or if there is no username/password in the input box

Deployment preview: https://logonoff.co/oauth-templates/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

/hold

I'd also like to wait for https://github.com/patternfly/patternfly 6.2.0 to pick up a change removing invalid CSS

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

Assignees

@rhamilto rhamilto

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@logonoff @openshift-ci-robot @rhamilto