Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up node:fs utimes, futimes , and lutimes #16634

Merged
merged 8 commits into from
Jan 23, 2025
Merged

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Jan 23, 2025

What does this PR do?

  • Handle EINTR
  • Use syscall interface on linux
  • Use UTIME_NOW which sets it to the current system time instead of getting the current time manually

How did you verify your code works?

  • Worked around an issue preventing fs-stat-bigint from fully being run
  • Added test-fs-stat-date.mjs

@robobun
Copy link

robobun commented Jan 23, 2025

Updated 3:02 AM PT - Jan 23rd, 2025

@Jarred-Sumner, your commit 79ad25d has 1 failures in #10390:


🧪   try this PR locally:

bunx bun-pr 16634

@Jarred-Sumner Jarred-Sumner changed the title Clean up node:fs utimens, futimes , and lutimes Clean up node:fs utimes, futimes , and lutimes Jan 23, 2025
@Jarred-Sumner Jarred-Sumner merged commit b54f3f3 into main Jan 23, 2025
68 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/utimens branch January 23, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants