Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove deprecated underline attribute #5581

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Jan 21, 2025

Small change to clean up deprecated underline attributes!

I was getting bothered in storybook files that this underline attribute is deprecated, but it's used in many examples.

Let's clean this up so developers don't add undesirable usage in their code when copying examples from Primer's storybook.

Changelog

New

Changed

Removed

  • Removed undesirable underline attribute usage in stories.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@khiga8 khiga8 added the skip changeset This change does not need a changelog label Jan 21, 2025
@khiga8 khiga8 requested a review from a team as a code owner January 21, 2025 20:47
@khiga8 khiga8 requested a review from langermank January 21, 2025 20:47
Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: 0acefdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-5581 January 21, 2025 20:49 Inactive
Copy link
Contributor

github-actions bot commented Jan 21, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.25 KB (0%)
packages/react/dist/browser.umd.js 104.56 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants