Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove deprecated underline attribute #5581

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const hoverCard = (
<Stack direction="horizontal" gap="none">
<Text weight="medium">monalisa</Text>
<Text color={'var(--fgColor-muted)'} ml={1}>
<Link inline underline muted href="#">
<Link inline muted href="#">
Monalisa Octocat
</Link>
</Text>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const hoverCard = (
<Stack direction="horizontal" gap="none">
<Text weight="medium">monalisa</Text>
<Text color={'var(--fgColor-muted)'} ml={1}>
<Link inline underline muted href="#">
<Link inline muted href="#">
Monalisa Octocat
</Link>
</Text>
Expand Down
6 changes: 3 additions & 3 deletions packages/react/src/Banner/Banner.examples.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export const WithCustomHeading = () => {
<Banner.Title as="h3">Info</Banner.Title>
<Banner.Description>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -120,7 +120,7 @@ export const InSidebar = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand Down Expand Up @@ -157,7 +157,7 @@ export const DismissBanner = () => {
description: (
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand Down
24 changes: 12 additions & 12 deletions packages/react/src/Banner/Banner.features.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const Critical = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -37,7 +37,7 @@ export const Info = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -56,7 +56,7 @@ export const Success = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -75,7 +75,7 @@ export const Upsell = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -94,7 +94,7 @@ export const Warning = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -113,7 +113,7 @@ export const Dismiss = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -131,7 +131,7 @@ export const DismissWithActions = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -152,7 +152,7 @@ export const WithHiddenTitle = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -171,7 +171,7 @@ export const WithHiddenTitleAndActions = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -192,7 +192,7 @@ export const DismissibleWithHiddenTitleAndActions = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -214,7 +214,7 @@ export const DismissibleWithHiddenTitleAndSecondaryAction = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand All @@ -234,7 +234,7 @@ export const WithActions = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Banner/Banner.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const Default = () => {
description={
<>
GitHub users are{' '}
<Link inline underline href="#">
<Link inline href="#">
now required
</Link>{' '}
to enable two-factor authentication as an additional security measure.
Expand Down
Loading