Makes CONTENT_ORIGIN not a required setting PULP-194 #6175
Conversation
git-hyagi
force-pushed
the
content-origin-none-update
branch
from
e5b2050 to
cb4755c
Compare
Can you really specifically outline what needs to happen here? Which test scenario and can you link to where that change would need to be made? |
|
Scenarios are the environments for each test job in the CI (e.g, "pulp", "s3", "azure" and "lowerbound"). What I understand is that some (arbitrary) set of scenarios should set CONTENT_ORIGIN and some should not. |
|
@pedro-psb this is really helpful, ty. This setting is defined earlier (L#1), and I'm not 100% sure what setting the same variable in two places in that would do. What do you think about us removing it from being set at L#1 and instead setting it on one or more of the other test runners? Also, I don't know what you mean about "similar control pair", what does that mean. |
|
Yeah, that sounds ideal, that shouldn't be set in the common settings part. I was refering to the notion of experiment-control groups, where we have isolated differences being tested (and similar properties for everything else). But that was a bit of a loose reasoning, if something goes wrong it will probably be obvious in any of those scenarios. |
To add more context the actual scenario_specific settings are set in the template_config.yml. Reapplying the template in the same commit is necessary. Line 60 in 13114a8 |
|
Thanks @mdellweg this is also helpful. Do you think we'll need to make any changes to the plugin template itself, or just update these and re-apply? Unforseen things can always come up, but I wanted to hear what you thought we'd run into. |
|
No template changes. That's what we have these variables for. |
git-hyagi
force-pushed
the
content-origin-none-update
branch
from
cb4755c to
9129d11
Compare
|
@git-hyagi I think this ticket has enough info on it for you to proceed making the variable changes and re-applying the template. Please come back with any questions at all. Thank you! |
git-hyagi
force-pushed
the
content-origin-none-update
branch
from
9129d11 to
4829da1
Compare
If `content_origin` is not set, the `distribution.base_url` will be defined with the relative path and the curl command in the test script will fail to run because of the missing hostname/address. ref: pulp/pulpcore#6175
git-hyagi
force-pushed
the
content-origin-none-update
branch
from
4829da1 to
3f8be97
Compare
|
The CI is probably failing because we depend on a change in pulp-cli tests: pulp/pulp-cli#1118 |
If `content_origin` is not set, the `distribution.base_url` will be defined with the relative path and the curl command in the test script will fail to run because of the missing hostname/address. ref: pulp/pulpcore#6175
If `content_origin` is not set, the `distribution.base_url` will be defined with the relative path and the curl command in the test script will fail to run because of the missing hostname/address. ref: pulp/pulpcore#6175 (cherry picked from commit 466f1eb)
If `content_origin` is not set, the `distribution.base_url` will be defined with the relative path and the curl command in the test script will fail to run because of the missing hostname/address. ref: pulp/pulpcore#6175 (cherry picked from commit 466f1eb)
git-hyagi
force-pushed
the
content-origin-none-update
branch
3 times, most recently
from
fa1f7e7 to
d7dc98b
Compare
template_config.yml
Outdated
| @@ -58,6 +58,7 @@ pulp_settings: | |||
| tmpfile_protection_time: 10 | |||
| upload_protection_time: 10 | |||
| pulp_settings_azure: | |||
| content_origin: "" | |||
git-hyagi
force-pushed
the
content-origin-none-update
branch
from
a2b5635 to
a1e1b61
Compare
git-hyagi
force-pushed
the
content-origin-none-update
branch
from
a1e1b61 to
e81499a
Compare
git-hyagi
force-pushed
the
content-origin-none-update
branch
from
e81499a to
09aeded
Compare
No description provided.