Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for msgSV.GovCloseChannel #695

Merged

Conversation

DongLieu
Copy link
Contributor

1. Summary

Fixes #617

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #695 (ba358fa) into main (7521baa) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
+ Coverage   13.40%   13.45%   +0.05%     
==========================================
  Files         243      243              
  Lines       63047    63047              
==========================================
+ Hits         8450     8483      +33     
+ Misses      53919    53886      -33     
  Partials      678      678              
Flag Coverage Δ
unittests 13.45% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

ThanhNhann
ThanhNhann previously approved these changes Oct 17, 2023
Copy link
Contributor

@ThanhNhann ThanhNhann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice work @DongLieu, I think you should check the channel is really closed in case successful with this function then we can merge

@ThanhNhann
Copy link
Contributor

And don't forget to update the branch with latest commit of branch main

@DongLieu
Copy link
Contributor Author

The function you mentioned is in the main branch, but in the repo we use v5.3.1 it doesn't have that function

@ThanhNhann
Copy link
Contributor

You can totally use the logic implemented in the function I mentioned to check that

@DongLieu
Copy link
Contributor Author

I added a check the channel is actually closed

joe-bowman
joe-bowman previously approved these changes Oct 19, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

s/expecErr/expectErr/
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit 1ed5da2 into quicksilver-zone:main Oct 23, 2023
7 of 8 checks passed
@joe-bowman joe-bowman deleted the dong/TestGovCloseChannel branch October 23, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants