-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for msgSV.GovCloseChannel #695
Test for msgSV.GovCloseChannel #695
Conversation
Codecov Report
@@ Coverage Diff @@
## main #695 +/- ##
==========================================
+ Coverage 13.40% 13.45% +0.05%
==========================================
Files 243 243
Lines 63047 63047
==========================================
+ Hits 8450 8483 +33
+ Misses 53919 53886 -33
Partials 678 678
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And don't forget to update the branch with latest commit of branch main |
The function you mentioned is in the main branch, but in the repo we use v5.3.1 it doesn't have that function |
You can totally use the logic implemented in the function I mentioned to check that |
I added a check the channel is actually closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
s/expecErr/expectErr/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1. Summary
Fixes #617
2.Type of change
3. Implementation details
4. How to test/use
5. Checklist
6. Limitations (optional)
7. Future Work (optional)