Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copies for security shield wizard flow #560

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

sergiupuhalschi-rdx
Copy link
Contributor

No description provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were moved to the corresponding section folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean these are deletions that were never made by the bot on the /en-US/ files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the files within /Content folder but I forgot to remove them from /en-US files and the keys are now duplicated (but only in /en-US files). The deletions in the current PR fix duplicates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the deletion from en-US files should happen automatically when bot sees that such files were removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, but it didn't, I remember also manually syncing the localization repo from crowdin and it still didn't delete these. I guess it's safe to delete them manually?

@sergiupuhalschi-rdx sergiupuhalschi-rdx marked this pull request as ready for review January 9, 2025 12:36
@sergiupuhalschi-rdx sergiupuhalschi-rdx self-assigned this Jan 9, 2025
@sergiupuhalschi-rdx sergiupuhalschi-rdx merged commit 46cfbdb into main Jan 9, 2025
@sergiupuhalschi-rdx sergiupuhalschi-rdx deleted the sp/shield-wizard-updates branch January 9, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants