Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copies for security shield wizard flow #560

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update copies for security shield wizard flow #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Content/2.0.1 - Security Shield Preparation/shieldSetupPrepareFactors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"shieldSetupPrepareFactors_addHardwareFactor_noDeviceButton": "I don’t have a hardware device",
"shieldSetupPrepareFactors_addAnotherFactor_title": "Add Another Factor",
"shieldSetupPrepareFactors_addAnotherFactor_subtitle": "You need to add **1 more factor** to begin building your Shield.",
"shieldSetupPrepareFactors_addAnotherFactor_passphraseHint": "Choosing a passphrase is only recommended for advanced users",
"shieldSetupPrepareFactors_addAnotherFactor_passphraseHint": "Choosing a mnemonic is only recommended for advanced users",
"shieldSetupPrepareFactors_addAnotherFactor_button": "Add Factor",
"shieldSetupPrepareFactors_completion_title": "Your Factors are Ready",
"shieldSetupPrepareFactors_completion_subtitleTop": "Now let’s build your Shield.",
Expand Down
4 changes: 2 additions & 2 deletions Content/2.0.1 - Security Shield Preparation/shieldSetupSelectFactors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"shieldSetupSelectFactors_title": "Select Factors for Transactions",
"shieldSetupSelectFactors_subtitle": "Choose the factors you’ll use to sign transactions. You’ll use **all** of these factors every time you send assets or log in to dApps.",
"shieldSetupSelectFactors_title": "Select Factors for Regular Access",
"shieldSetupSelectFactors_subtitle": "Choose the factors you’ll use for regular access. You’ll use **all** of these factors every time you send assets.",
"shieldSetupSelectFactors_buildButtonTitle": "Build Shield"
}
10 changes: 0 additions & 10 deletions en/en-US/Content/Shield Setup Onboarding/shieldSetupOnboarding.json
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were moved to the corresponding section folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean these are deletions that were never made by the bot on the /en-US/ files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the files within /Content folder but I forgot to remove them from /en-US files and the keys are now duplicated (but only in /en-US files). The deletions in the current PR fix duplicates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the deletion from en-US files should happen automatically when bot sees that such files were removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, but it didn't, I remember also manually syncing the localization repo from crowdin and it still didn't delete these. I guess it's safe to delete them manually?

This file was deleted.

17 changes: 0 additions & 17 deletions en/en-US/Content/Shield Setup Prepare Factors/shieldSetupPrepareFactors.json
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions en/en-US/Content/Shield Setup Select Factors/shieldSetupSelectFactors.json
View file
Open in desktop

This file was deleted.