chore(ci): run lint, test and type check on every pull request #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (42%)
|
asdolo
force-pushed
the
chore/ci_run_lint_test_and_type_check_on_every_pull_request
branch
from
1ff4676 to
080a27f
Compare
guillermomachado
approved these changes
Aug 5, 2024
asdolo
deleted the
chore/ci_run_lint_test_and_type_check_on_every_pull_request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR changes the Lint, Test and Type Check GH Actions so they always run on any pull request, and not only the ones having main/master as base branch.
Why did you do this?
Because in some scenarios we have PRs for branches pointing to other branches than main/master and it's nice if we can start running checks on them.
Who/what does this impact?
Template maintainers.
How did you test this?
Still untested. Will edit this comment with more information after these changes are applied.