Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): run lint, test and type check on every pull request #24

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint-ts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# ✍️ Description:
# This action is used to run eslint checks
# Runs on pull requests and pushes to the main/master branches
# Runs on any pull request, and also when pushing to main/master
# Based on the event type:
# - If it's a pull request, it will run eslint, then add the check to the PR as well as annotate the code with the errors and warnings.
# - If it's a push to main/master, it will run the type checking and fail if there are any errors.
Expand All @@ -16,7 +16,7 @@ on:
push:
branches: [main, master]
pull_request:
branches: [main, master]
types: [opened, synchronize]

jobs:
lint:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# ✍️ Description:
# This action is used to run unit tests
# Runs on pull requests and pushes to the main/master branches
# Runs on any pull request, and also when pushing to main/master
# Based on the event type:
# - If it's a pull request, it will run the tests and post a comment with coverage details.
# - If it's a push to main/master, it will run the tests and add the check to the commit.
Expand All @@ -16,7 +16,7 @@ on:
push:
branches: [main, master]
pull_request:
branches: [main, master]
types: [opened, synchronize]

jobs:
test:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/type-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# ✍️ Description:
# This action is used to run the type-check on the project.
# Runs on pull requests and pushes to the main/master branches
# Runs on any pull request, and also when pushing to main/master
# Based on the event type:
# - If it's a pull request, it will run type checking, then add the check to the PR as well as annotate the code with the errors using reviewdog.
# - If it's a push to main/master, it will run the type checking and fail if there are any errors.
Expand All @@ -16,7 +16,7 @@ on:
push:
branches: [main, master]
pull_request:
branches: [main, master]
types: [opened, synchronize]

jobs:
type-check:
Expand Down
Loading