[Noetic] Use opencv3 on buster #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
|
As of the latest commit tests pass for be both using Buster and Focal; the cause was a different component name for finding boost::python in Buster versus Focal. |
mjcarroll
approved these changes
May 19, 2020
| set(_opencv_version 3) | ||
| endif() | ||
|
|
||
| find_package(OpenCV ${_opencv_version4} REQUIRED |
There was a problem hiding this comment.
I think this contains a typo and should be ${_opencv_version} not '${_opencv_version4}'
There was a problem hiding this comment.
Definitely. Linking to your PR #333
This was referenced May 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROS Noetic uses OpenCV 4 on Focal, but OpenCV 3.2 on Buster: https://www.ros.org/reps/rep-0003.html#noetic-ninjemys-may-2020-may-2025
AccessFlagtype added in OpenCV 4 if using 3.2I'm opening this PR a bit early; I'm unable to successfully run tests on my system because the cvtColorForDisplay test fails; but the import is strange. I'm wondering if it will work in the PR job:Edit Tests pass; ready for review and hopefully merge and release 🚀