set ns as '~' when namespace is '~' #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knorth55
force-pushed
the
dyn-server-namespace
branch
from
0a3b870 to
d7e41a3
Compare
|
I change this PR target to |
|
can anyone please review and merge this PR? |
1 similar comment
|
can anyone please review and merge this PR? |
|
kindly ping. can anyone review and merge this PR? |
|
@gbiggs can you also check this PR, too? |
gbiggs
approved these changes
Oct 4, 2022
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we pass
namespace='~'indynamic_reconfigure.Server,self.nsis set as~/.dynamic_reconfigure.Servermakes/set_parametersservice withself.ns = ~/, which causes the issue below inrqt_reconfigure.ros-visualization/rqt_reconfigure#92
self.nsshould be~whennamespace='~'ornamespace='', so I made this PR.I'm not super confident in this PR, so I want to do discussion about this feature.
Signed-off-by: Michael Carroll [email protected]