-
Notifications
You must be signed in to change notification settings - Fork 736
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
out of curiosity @stewartjarod what were the issues you ran into in running tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a cool idea!
to make sure, the main capability the API offers is query right? not actually being able to make a purchase decision yet?
@@ -27,8 +27,8 @@ pytest = "7.2.1" | |||
pytest-dotenv = "0.5.2" | |||
pytest_httpserver = "1.0.8" | |||
pytest-mock = "3.11.1" | |||
typing-inspect = "0.8.0" | |||
typing_extensions = "^4.5.0" | |||
typing-inspect = "0.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the understanding with these Python types that it is good to keep them up to date and that they are entirely backward compatible. I could be wrong! I come from mostly a TS background and try to use types for everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can roll this back if it will cause issues
I wasn't able to get the async tests to pass. Right, at this time we provide a query for products and recommendations. Looking to expand from there. 😀 |
Ah, that's a weird failure. While I'm figuring this out, @jerryjliu do you want me to revert the package update for typings? |
Tests should pass now 👍 |
Ah, that's a new one. Type responses like that must not be supported in 3.8. Sorry for the issues here with tests. Adding future annotations seemed to do the trick here. |
Let me know if there is anything else I can do here! Thank you for your support. |
Description
Ionic is a shopping assistant tool for llms. I've added the tool, which depends on our Ionic API SDK library.
While there, I updated the typing packages.
Note: I had issues with running tests locally, even on main, so I'm not entirely sure if this is good to merge without a CI/CD step for tests.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods