Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves spatialdata_io.xenium() capability to read in xeniumranger v3.0.1.1 resegemented data #244

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Pancreas-Pratik
Copy link

@Pancreas-Pratik Pancreas-Pratik commented Nov 30, 2024

Resolves #195 (comment)

  • parses out xeniumranger v3.0.1.1 version from new spec XENIUM_RANGER = "xenium_ranger", which allows the re-segmented /outs/ data to pass through the existing spatialdata_io.xenium() successfully

(this is my first pull request... in any repository... please correct me if I am doing something wrong)

Pancreas-Pratik and others added 3 commits November 29, 2024 20:26
…ion detection after resegment

needed within xenium.py for correct xenium() parsing/branching of /outs/ folder path input generated from the xeniumranger v3.0.1.1 resegment
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.33%. Comparing base (ed60d9f) to head (05ece63).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_io/readers/xenium.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   45.31%   45.33%   +0.02%     
==========================================
  Files          22       22              
  Lines        2143     2144       +1     
==========================================
+ Hits          971      972       +1     
  Misses       1172     1172              
Files with missing lines Coverage Δ
src/spatialdata_io/_constants/_constants.py 100.00% <100.00%> (ø)
src/spatialdata_io/readers/xenium.py 71.56% <66.66%> (-0.14%) ⬇️

@LucaMarconato
Copy link
Member

Thank you @Pancreas-Pratik for making a PR! I will try this soon and give my comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't read re-segmented Xenium data
3 participants