Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes pre-commit from nix check so CI only checks code #12

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Skyfold
Copy link
Contributor

@Skyfold Skyfold commented Dec 19, 2024

hpack, fourmolu, hlint and nixfmt output depend on the exact versions being used to have the same output. The pre-commit-check can fail if even minor versions are different. This makes the check very brittle.

hpack, fourmolu, hlint and nixfmt output depend on the exact versions
being used to have the same output. The pre-commit-check can fail if
even minor versions are different. This makes the check very brittle.
@seanhess
Copy link
Owner

Great! I added you to the contributors list, btw. Thanks

@seanhess seanhess merged commit 4a82933 into seanhess:main Dec 19, 2024
1 check passed
@Skyfold Skyfold mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants