Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the positioning issue of the Facebook icon and the Apply button. #68

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Fix the positioning issue of the Facebook icon and the Apply button. #68

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
638fccb
Corrected npm start command in README.md for local development
mayura-andrew Jan 2, 2024
04537ab
Merge branch 'sef-global:main' into main
mayura-andrew Jan 4, 2024
638ec27
Fixed README
mayura-andrew Jan 4, 2024
0a2cddf
Merge branch 'sef-global:main' into main
mayura-andrew Jan 9, 2024
335507c
Fixed Facebook icon in nav bar and Apply button issue
mayura-andrew Jan 9, 2024
f6fea0b
Fixed Apply button and See more button used TailwindCSS
mayura-andrew Jan 10, 2024
92a661b
Backend API URL Problem
mayura-andrew Jan 10, 2024
32595c8
Fixed Apply button and See more buttons (Removed template iterals)
mayura-andrew Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/Home/Home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ const Home: React.FC = () => (
<div style={{ marginTop: '40px' }}>
<Button
className={styles.homePageMainButton}
type={'primary'}
style={{ marginRight: '20px', marginBottom: '20px' }}
style={{
marginRight: '20px',
marginBottom: '20px',
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use tailwind css here @mayura-andrew

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applyandseemore.mp4

>
Apply
</Button>
Expand Down
9 changes: 4 additions & 5 deletions src/components/Layout/MenuDrawer/MenuDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
TwitterOutlined,
LinkedinFilled,
InstagramOutlined,
FacebookFilled,
} from '@ant-design/icons';
import { Avatar, Button, Drawer, Space, Typography } from 'antd';

Expand Down Expand Up @@ -55,11 +56,9 @@ const MenuDrawer: React.FC<MenuDrawerProps> = ({ openMenu, setOpenMenu }) => {
target="_blank"
rel="noreferrer"
>
<Button
className={styles.antButton}
shape="circle"
icon={<img src="/facebook-icon.png" width={20} />}
/>
<Button className={styles.antButton} shape="circle">
<FacebookFilled className={styles.antIcon} />
</Button>
</a>
<a
href="https://twitter.com/goasksef"
Expand Down
9 changes: 4 additions & 5 deletions src/components/Layout/Navbar/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
TwitterOutlined,
LinkedinFilled,
InstagramOutlined,
FacebookFilled,
} from '@ant-design/icons';
import { Button, Col, Row, Space, Typography } from 'antd';

Expand Down Expand Up @@ -110,11 +111,9 @@ const Navbar: React.FC = () => {
target="_blank"
rel="noreferrer"
>
<Button
className={styles.antButton}
shape="circle"
icon={<img src="/facebook-icon.png" width={20} />}
/>
<Button className={styles.antButton} shape="circle">
<FacebookFilled className={styles.antIcon} />
</Button>
</a>
<a
href="https://twitter.com/goasksef"
Expand Down