Fix the positioning issue of the Facebook icon and the Apply button. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjula-sack
requested changes
Jan 10, 2024
src/components/Home/Home.tsx
Outdated
Comment on lines
29
to
32
| style={{ | ||
| marginRight: '20px', | ||
| marginBottom: '20px', | ||
| }} |
There was a problem hiding this comment.
Let's use tailwind css here @mayura-andrew
There was a problem hiding this comment.
applyandseemore.mp4
anjula-sack
requested changes
Jan 11, 2024
src/components/Home/Home.tsx
Outdated
| Apply | ||
| </Button> | ||
| <Button | ||
| className={`flex justify-center items-center mr-5 mb-5 text-black py-1 px-16 rounded w-40 h-9 font-sans font-bold`} |
There was a problem hiding this comment.
We don't need template literals here.
Suggested change
| className={`flex justify-center items-center mr-5 mb-5 text-black py-1 px-16 rounded w-40 h-9 font-sans font-bold`} | |
| className="flex justify-center items-center mr-5 mb-5 text-black py-1 px-16 rounded w-40 h-9 font-sans font-bold" |
src/components/Home/Home.tsx
Outdated
| <Button className={styles.homePageMainButton}>See more</Button> | ||
| <div className="flex mt-10"> | ||
| <Button | ||
| className={`flex justify-center items-center mr-5 mb-5 bg-blue-500 hover:bg-blue-700 text-white py-1 px-16 rounded w-40 h-9 font-sans font-bold`} |
There was a problem hiding this comment.
Suggested change
| className={`flex justify-center items-center mr-5 mb-5 bg-blue-500 hover:bg-blue-700 text-white py-1 px-16 rounded w-40 h-9 font-sans font-bold`} | |
| className="flex justify-center items-center mr-5 mb-5 bg-blue-500 hover:bg-blue-700 text-white py-1 px-16 rounded w-40 h-9 font-sans font-bold" |
|
Thank you :) |
mayura-andrew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #65
Goals
The goal is to improve the user interface by fixing the positioning of the Facebook icon and the Apply button.
Approach
The approach taken was to modify the CSS styles of the Facebook icon and the Apply button.
Screenshots
Checklist
Related PRs
N/A
Test environment
OS - Fedora Linux 39 (KDE Plasma) x86_64
NodeJS - 20.10.0
Learning
N/A