-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the positioning issue of the Facebook icon and the Apply button. #68
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
638fccb
Corrected npm start command in README.md for local development
mayura-andrew 04537ab
Merge branch 'sef-global:main' into main
mayura-andrew 638ec27
Fixed README
mayura-andrew 0a2cddf
Merge branch 'sef-global:main' into main
mayura-andrew 335507c
Fixed Facebook icon in nav bar and Apply button issue
mayura-andrew f6fea0b
Fixed Apply button and See more button used TailwindCSS
mayura-andrew 92a661b
Backend API URL Problem
mayura-andrew 32595c8
Fixed Apply button and See more buttons (Removed template iterals)
mayura-andrew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -24,14 +24,18 @@ const Home: React.FC = () => ( | |||||
Unlock Mentorship Opportunities with ScholarX | ||||||
</Text> | ||||||
<div style={{ marginTop: '40px' }}> | ||||||
<Button | ||||||
className={styles.homePageMainButton} | ||||||
type={'primary'} | ||||||
style={{ marginRight: '20px', marginBottom: '20px' }} | ||||||
> | ||||||
Apply | ||||||
</Button> | ||||||
<Button className={styles.homePageMainButton}>See more</Button> | ||||||
<div className="flex mt-10"> | ||||||
<Button | ||||||
className={`flex justify-center items-center mr-5 mb-5 bg-blue-500 hover:bg-blue-700 text-white py-1 px-16 rounded w-40 h-9 font-sans font-bold`} | ||||||
> | ||||||
Apply | ||||||
</Button> | ||||||
<Button | ||||||
className={`flex justify-center items-center mr-5 mb-5 text-black py-1 px-16 rounded w-40 h-9 font-sans font-bold`} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't need template literals here.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok got it 👍 |
||||||
> | ||||||
See more | ||||||
</Button> | ||||||
</div> | ||||||
</div> | ||||||
</Col> | ||||||
<Col xs={24} md={24} xl={12} style={{ marginTop: '40px' }}> | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
export const API_URL = 'http://localhost:3000/api'; | ||
export const API_URL = 'http://localhost:4000/api'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.