fixing hands fsw representing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix right hand rendering
AmitMY
requested changes
Jul 12, 2024
synthetic_signwriting/generator.py
Outdated
| @@ -241,6 +241,9 @@ def render_fsw(self): | |||
| generated_left_hand = str(hex(keyframe.left_hand_signwriting))[2:] | |||
| generated_face = '2ff00' # TODO adding synthetic face option | |||
|
|
|||
| # adding 8 offset to the left hand | |||
| generated_left_hand = str(hex(int(generated_left_hand, 16) + 0x8))[2:] | |||
There was a problem hiding this comment.
this does not belong here.
it belongs at lines 86~
if not right hand, then mirror the symbol (add 0x8)
There was a problem hiding this comment.
you right, I updated it in the if-else condition
changing the location of the mirroring of the left fsw sign
AmitMY
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding 8 for the left hand fsw hex value