Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing hands fsw representing #3

Merged
merged 4 commits into from
Jul 13, 2024
Merged

fixing hands fsw representing #3

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c958f63
fix right hand rendering
RotemZilberman Jul 12, 2024
bbea461
Merge pull request #2 from RotemZilberman/adding-generator-for-fsw
RotemZilberman Jul 12, 2024
3e6bba3
changing the location of the mirroring of the left fsw sign
RotemZilberman Jul 12, 2024
9c609ec
Merge pull request #3 from RotemZilberman/adding-generator-for-fsw
RotemZilberman Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions synthetic_signwriting/generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ def render_fsw(self):
generated_left_hand = str(hex(keyframe.left_hand_signwriting))[2:]
generated_face = '2ff00' # TODO adding synthetic face option

# adding 8 offset to the left hand
generated_left_hand = str(hex(int(generated_left_hand, 16) + 0x8))[2:]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not belong here.
it belongs at lines 86~
if not right hand, then mirror the symbol (add 0x8)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you right, I updated it in the if-else condition


fsw += f"M538x552S{generated_face}482x483S{generated_right_hand}522x522S{generated_left_hand}455x521"
return fsw

Expand Down
Loading