internal: remove unnecessary step from Ubuntu CI #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic11
commented
Dec 22, 2024
| - name: Copy log file from container to workspace | ||
| if: failure() | ||
| run: | | ||
| sudo docker cp configure_container:/src/vcpkg/buildtrees/rsm-bsa/install-x64-linux-dbg-out.log ${{github.workspace}}/install-x64-linux-dbg-out.log |
There was a problem hiding this comment.
No need, the whole workspace is mounted with -v ${{github.workspace}}:/src
See also https://github.com/skyrim-multiplayer/skymp/actions/runs/12456833845?pr=2275
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to e75cfd1 in 8 seconds
More details
- Looked at
30lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/pr-ubuntu-docker.yml:86
- Draft comment:
The removal of thedocker cpcommand and the--name configure_containeroption is appropriate since the log file is directly accessed from the workspace path. This change simplifies the workflow without affecting functionality. - Reason this comment was not posted:
Confidence changes required:0%
The removal of thedocker cpcommand and the--name configure_containeroption is appropriate since the log file is directly accessed from the workspace path. This change simplifies the workflow without affecting functionality.
Workflow ID: wflow_uPewamK8wZXC5RhD
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Pospelove
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Removes unnecessary log file copy step from Ubuntu CI workflow, directly uploading from original path.
.github/workflows/pr-ubuntu-docker.yml.install-x64-linux-dbg-out.logfromvcpkg/buildtrees/rsm-bsa/path.This description was created by
for e75cfd1. It will automatically update as commits are pushed.