Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: remove unnecessary step from Ubuntu CI #2275

Merged
merged 4 commits into from
Dec 23, 2024
Merged

internal: remove unnecessary step from Ubuntu CI #2275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d983e2d
internal: remove unnecessary step from Ubuntu CI
nic11 Dec 22, 2024
18e69d6
test failure
nic11 Dec 22, 2024
f9b17c7
proof
nic11 Dec 22, 2024
e75cfd1
revert
nic11 Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/pr-ubuntu-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,24 +72,18 @@ jobs:
options: |
-v ${{github.workspace}}:/src
-u skymp
--name configure_container
run: |
cd /src \
&& ./build.sh --configure \
-DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} \
-DUNIT_DATA_DIR="/src/skyrim_data_files"

- name: Copy log file from container to workspace
if: failure()
run: |
sudo docker cp configure_container:/src/vcpkg/buildtrees/rsm-bsa/install-x64-linux-dbg-out.log ${{github.workspace}}/install-x64-linux-dbg-out.log
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, the whole workspace is mounted with -v ${{github.workspace}}:/src

See also https://github.com/skyrim-multiplayer/skymp/actions/runs/12456833845?pr=2275


- name: Upload vcpkg failure logs
if: failure()
uses: actions/upload-artifact@v4
with:
name: install-x64-linux-dbg-out.log
path: ${{github.workspace}}/install-x64-linux-dbg-out.log
path: ${{github.workspace}}/vcpkg/buildtrees/rsm-bsa/install-x64-linux-dbg-out.log

- name: Upload compile_commands.json
uses: actions/upload-artifact@v4
Expand Down
Loading