New munitions descriptions

[Nox38]

About the PR

Added descriptions to every cartridge, magazine, ammo box, and firearm. These new descriptions should help scratch that realism itch some of us feel while also making them more descriptive for non-gun nerds. The names of the calibers themselves have also been tweaked for realism and to help differentiate them.

Why / Balance

The why is pretty obvious: more details is always nice! The balance is completely unchanged; this just changes cartridge names and adds descriptions. We plan to make a second PR with adjustments to the gun balance after this is merged.

Technical details

Renamed the following calibers: .25 caseless -> .20 caseless, .35 auto -> .38 auto, .45 magnum -> .44 magnum, .25 rifle > .223 rifle, .30 rifle -> .308 rifle, .50 shell -> 12 gauge, grenade -> grenade cartridge.
All new descriptions can be found and edited on this google doc
Feel free to use the comment mode to put in your own changes and I will add them into the game.

The Kardashev-Mosin now uses its own .235 caliber (the previously unused CartridgeHeavyRifle in the game files). Note that its speedloader is still named 'SpeedLoaderLightRifle', I couldn't change it without errors.

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Mosin speedloader has had its ID changed from “light” to “heavy”.

Changelog
🆑 Nox38, lorahart2

• add: Added descriptions for all of the cartridges, ammo boxes, magazines, and the like. Replaced or modified descriptions for all (currently used) firearms.
• add: Added a new caliber for the Mosin and any other full-power rifles: .235 rifle.
• tweak: Renamed most calibers to be slightly more realistic and descriptive.
  -->

[Nox38]

Please ignore the changes:map tag, I think it added that automatically because I had to edit the salvage maps when I changed the ID of the Mosin speedloader.

[K-Dynamic]

Does anyone know where .50 shell comes from? Because I'd just rename it to 12G.

[Nox38]

@K-Dynamic All of the calibers use inches. 12 gauge would actually be .725, so I might as well change it to that.

[ArtisticRoomba]

12 gauge as .725 is unfathomably cursed, I would just have it be named 12G shells or something similar.

[K-Dynamic]

@K-Dynamic All of the calibers use inches. 12 gauge would actually be .725, so I might as well change it to that.

I thought people refer to shotgun shells as gauges more than calibers though

Also if you change it and it gets merged we'll end up with a merge conflict; I can rename them on your behalf instead.

[Nox38]

Im aware theres a function to merge all the suggestions in one commit, its just greyed out on mobile

[Nox38]

Ready to go

[southbridge-fur]

I hate to rain on your parade, but aren't the names of firearms copyrighted?

[lorahart2]

I hate to rain on your parade, but aren't the names of firearms copyrighted?

We haven't changed the name of any firearms just ammo which isn't copyrighted also added new descriptions for the firearms to add more flavour and finally changed the tip colour of the rounds to help distinguish their ammo type

[Nox38]

@southbridge-fur the closest weapons to their real-life counterparts (in name) are the AKMS (AKM, I'm fairly sure the soviet union is not going to complain about that one), and the Vector (KRISS Vector, the gun is not used in-game anymore and KRISS is specifically the one company who is super supportive of you putting their gun in video games). No gun names have been changed by this PR.

[southbridge-fur]

I hate to rain on your parade, but aren't the names of firearms copyrighted?

We haven't changed the name of any firearms just ammo which isn't copyrighted also added new descriptions for the firearms to add more flavour and finally changed the tip colour of the rounds to help distinguish their ammo type

@southbridge-fur the closest weapons to their real-life counterparts (in name) are the AKMS (AKM, I'm fairly sure the soviet union is not going to complain about that one), and the Vector (KRISS Vector, the gun is not used in-game anymore and KRISS is specifically the one company who is super supportive of you putting their gun in video games). No gun names have been changed by this PR.

good, just wanted to be sure. I saw the AKMS and assumed other firearms had been changed as well.

[ArtisticRoomba]

A lot of suggestions. Some inconsistent descriptions, a lot of fluff IMO, etc.

Some descriptions are really good though. I think it adds character to the atmosphere of SS14.

[lorahart2]

I did want to add we added some dirty harry references in the revolvers

[K-Dynamic]

Looking back at this, can I ask why we're not using real-world names for bullets (such as 9x19mm parabellum or 7.62x51mm NATO)

[lorahart2]

We are it's just the metric system was phased so everything is in inches 223 is 5.56 and.308 is 7.62
The only weird thing is the pistols using essentially 380 instead of 9mil or 45

[Nox38]

Looking back at this, can I ask why we're not using real-world names for bullets (such as 9x19mm parabellum or 7.62x51mm NATO)

I just followed the convention of all the calibers using inches rather than mm, though it could be interesting to make the syndicate only calibers in millimeters

[FloatingFeeling]

The shotgun doesn't miss.
Love the new descs and the vibe they give off, good PR