Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backword compatibility check on hrpsys / rtmros_common #449

Closed
k-okada opened this issue Apr 29, 2014 · 4 comments
Closed

backword compatibility check on hrpsys / rtmros_common #449

k-okada opened this issue Apr 29, 2014 · 4 comments

Comments

@k-okada
Copy link
Member

k-okada commented Apr 29, 2014

From (fkanehiro/hrpsys-base#210, fkanehiro/hrpsys-base#204, start-jsk/hrpsys#76)
here is my proposal (at this moment) @130s, @garaemon, @snozawa

A: hrpsys-base

  1. define "StableRTC" on hrpsys, which includes (seq, sh, fk, co, el, log),

1.1 current "released" robots only uses in these plugins (hiro)
2. keep StableRTC's backword compatibility, even if the version of hrpsys move to 315.2.x, it working with 315.1.x, as long as you uses "StableRTC"

2.1 We have't agreed when we should terminate or change "StableRTC" yet, currently it is just as long as possible...

2.2 https://travis-ci.org/fkanehiro/hrpsys-base/builds/23923220 is the PR to check if newer code is working on 315.1.x (see [1])
3. release current latest version to deb release, so it going to be 315.2.x or 315.3.x, which include latest code as well as backward compatibility to 315.1.x

B: rtmros_common

  1. this will compile against latest hrpsys-base, so it going to be 315.2.x or 315.3.x
  2. every PR is tested if it works with 315.1.x, using test case defined in 1
  3. release current latest version to deb release

The idea behind this is to split the source code into stable and experimental, within one package (directory), and keep stable as stable and working on experimental.
so people who would like to keep backward compatibility, they can use this code as long as you relay on stable code and if you like to test experimental behavior, write code anything you want as long as you did not brake stable code.

[1] backward compatibility test in test hrpsys-base

TEST_TYPE=work_with_downstream

 # check newer version of hrpsys works on current rtmros_common deb package
 # [hrpsys:new] <-> [rtmros_common:old (compiled on hrpsys:old)]

TEST_TYPE=work_with_315_1_10

# check rtmros_common compiled on newer version of hrpsys works with deb version of hrpsys
# [hrpsys:old] <-> [rtmros_common:new (compiled on hrpsys:new)]
@k-okada
Copy link
Member Author

k-okada commented Apr 29, 2014

If this idea is ok, then the process is

Discussion: this process jumps 315.1.10 to 315.2.0, another idea is to create 315.1.11 that only contains k-okada/hrpsys-base@53de9aa

@130s
Copy link
Contributor

130s commented Apr 30, 2014

+1
Looks like so much are done already for backward-compatibility test!

One trivial thing,

TEST_TYPE=work_with_downstream
:
TEST_TYPE=work_with_315_1_10 

These names were hard for me to grab the idea initially. But once I noticed that they are rooted from hrpsys-base, they make sense.

@snozawa
Copy link
Contributor

snozawa commented Apr 30, 2014

+1
I agree with this compatibility to continuous development.

As for definition of stable RTC,I asked the following question:
fkanehiro/hrpsys-base#212

@k-okada
Copy link
Member Author

k-okada commented May 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants