-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: possible crash #57
Conversation
- unstable crash on second received code - unstable crash on timeout
be3f7d3
to
85c5b38
Compare
…update-workflow # Conflicts: # pubspec.yaml
The base branch was changed.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 4 4
Lines 82 82
=======================================
Hits 79 79
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Related tasks
Fixes #10 , might also affect #34 , #39 and #51
Changes
lastResult
field tonull
when success or error message was delivered to prevent calling it more than once, which causesRuntimeException
Troubles (optional)
Result
in class field, waiting forBroadcastReceiver
callbacks and using it inonActivityResult
looks kind on unstable. Fixing it will probably lead to significant changes in the API.Note (optional)
Checklist for self-check
Checklist for reviewers
Design:
Functionality:
Complexity:
Tests:
Naming:
Comments:
Documentation: