Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible crash #57

Merged
merged 11 commits into from
Jul 12, 2023
Merged

fix: possible crash #57

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
85c5b38
fix: possible crash
tinted-knight Jul 6, 2023
38ec4ba
feat(version): added fvm usage
plasticfiresam Jul 10, 2023
accb6a5
feat(version): updated usage for future workflow usage
plasticfiresam Jul 10, 2023
4151f8c
feat(version): read version from fvm config
plasticfiresam Jul 11, 2023
e39349b
fix(version): pick flutter version from fvm config
plasticfiresam Jul 11, 2023
6964d97
fix(version): up surf_lint_rules to evade invariant_booleans rule
plasticfiresam Jul 11, 2023
bd91a7c
fix(version): up surf_lint_rules to evade invariant_booleans rule
plasticfiresam Jul 11, 2023
454b91b
Merge remote-tracking branch 'origin/feat-update-workflow' into feat-…
plasticfiresam Jul 11, 2023
cef0607
fix(example): fix example to comply analyzer
plasticfiresam Jul 11, 2023
36d48c5
Merge branch 'feat-update-workflow' into fix_second_code_crash
plasticfiresam Jul 11, 2023
f434c9e
Merge branch 'main' into fix_second_code_crash
plasticfiresam Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion android/src/main/kotlin/ru/surfstudio/otp_autofill/OTPPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,15 @@ public class OTPPlugin : FlutterPlugin, MethodCallHandler, PluginRegistry.Activi
// Get SMS message content
val message = data.getStringExtra(SmsRetriever.EXTRA_SMS_MESSAGE)
lastResult?.success(message)
lastResult = null
} else {
// Consent denied. User can type OTC manually.
}
credentialPickerRequest -> if (resultCode == Activity.RESULT_OK && data != null) {
val phoneNumber =
Identity.getSignInClient(context!!).getPhoneNumberFromIntent(data)
lastResult?.success(phoneNumber)
lastResult = null
}
}
return true
Expand Down Expand Up @@ -170,6 +172,7 @@ public class OTPPlugin : FlutterPlugin, MethodCallHandler, PluginRegistry.Activi

override fun onFailure() {
lastResult?.error("408", "Timeout exception", null)
lastResult = null
}
}
}
Expand All @@ -182,11 +185,15 @@ public class OTPPlugin : FlutterPlugin, MethodCallHandler, PluginRegistry.Activi
smsRetrieverBroadcastReceiver = SmsRetrieverReceiver().also {
it.smsBroadcastReceiverListener = object : SmsRetrieverReceiver.SmsRetrieverBroadcastReceiverListener {
override fun onSuccess(sms: String?) {
sms?.let { it -> lastResult?.success(it) }
sms?.let { it ->
lastResult?.success(it)
lastResult = null
}
}

override fun onFailure() {
lastResult?.error("408", "Timeout exception", null)
lastResult = null
}
}
}
Expand Down