Server: Replace lazy static with once cell everywhere #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-james
approved these changes
Jul 25, 2023
|
Open source review: Our existing solution
|
svix-nick
force-pushed
the
nick/once-lazy-cell-static
branch
from
9331ea6 to
eafae9c
Compare
|
Looks good to me! |
svix-nick
added a commit
that referenced
this pull request
Aug 24, 2023
See also #1024 lazy_static is unmaintained, once_cell is the new hotness. This PR swaps out the one lazy_static invocation for the equivalent lazy construct from once_cell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
lazy_staticcrate has not received maintenance in about four years, and has generally been deprecated in favor ofonce_cell. The latter's interface is being incorporated into the standard library.Solution
This PR simply swaps out
lazy_staticmacro invocations foronce_cell'sLazyinterface.