Fix race in memberlist.MakeChange #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Nov 18, 2024
dnr
added a commit
to temporalio/temporal
that referenced
this pull request
Nov 19, 2024
## What changed? Pick up race fix from temporalio/ringpop-go#16 ## Why? fix rare data race ## How did you test it? will be tested in CI, release validation ## Potential risks low, the previous code already obtained the same rlock on the same path, so there shouldn't be any risk of new deadlocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Change locking in MakeChange to include
m.local, and avoid making a copy.Why?
Fix race, make more efficient.
Checklist
unit tests, will be tested in temporal server tests