Print local URL instead of network #1740
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
Draft
| @@ -219,7 +219,7 @@ def listen_to_dashboard(proc: subprocess.Popen, pipe, out, started): | |||
| line # store the url when dashboard is started | |||
| ) | |||
| else: | |||
| if "Network URL: " in line: | |||
| if "Local URL: " in line: | |||
There was a problem hiding this comment.
just curious why we are spelling out "Local" here? can "URL" suffice?
There was a problem hiding this comment.
There are three URLs, Local, External and Network. Want to print specifically the local one
sfc-gh-dhuang
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Print local URL instead of network for dashboard
Other details good to know for developers
anyone running in a vm we just rely on them knowing the IP of their server
Type of change
not work as expected)
Important
Fixes URL display in
listen_to_dashboardto print "Local URL" instead of "Network URL" inrun.py.listen_to_dashboardfunction inrun.pyto print "Local URL" instead of "Network URL" for local dashboard access.This description was created by
for 8bff546. It will automatically update as commits are pushed.