Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print local URL instead of network #1740

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Print local URL instead of network #1740

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2be6a84
patch
Jan 16, 2025
938a0c6
update to local url print
Jan 22, 2025
8bff546
Merge branch 'main' into josh/local_url
sfc-gh-jreini Jan 22, 2025
4db5667
Merge branch 'main' into josh/local_url
sfc-gh-jreini Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dashboard/trulens/dashboard/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def listen_to_dashboard(proc: subprocess.Popen, pipe, out, started):
line # store the url when dashboard is started
)
else:
if "Network URL: " in line:
if "Local URL: " in line:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious why we are spelling out "Local" here? can "URL" suffice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are three URLs, Local, External and Network. Want to print specifically the local one

url = line.split(": ")[1]
url = url.rstrip()
print(f"Dashboard started at {url} .")
Expand Down