bazel-bsp server auto-update based on configured version #30
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mnoah1
added a commit
that referenced
this pull request
Jan 7, 2025
Updates the default bazel-bsp server version that gets installed by this extension. There is also a new feature flags data field in the initialization request that needs to be set here (currently only Python is behind a flag, Java is always enabled). This version is necessary to support newly added debug support via the test explorer. With the newly added changes in #30, users that have a different version than the one specified will be auto-updated to the matching version. Verified core extension workflows with this version: - Syncing test targets - Run with/without coverage - Run with debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a version check during the server initialization process. When the installed version does not match what is configured in VS Code settings (
bazelbsp.serverVersion), the installer will be run to get the required version. This will ensure that a user's installed bazel-bsp version stays in sync with the version expected by this extension.Also update jdk version used by Coursier as newer versions of bazel-bsp require Java 17+, to get this working. As a follow-up we can add in some additional logic here to depend on system Java where its version is new enough.