-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch validation of computer samples against their XSD #102
Batch validation of computer samples against their XSD #102
Conversation
usage() { | ||
cat <<EOF | ||
Usage: ${BASE_COMMAND:-$(basename "${BASH_SOURCE[0]}")} [ADDITIONAL_ARGS] | ||
|
||
Produces a validation report for a file set designated in the pipeline \"${XPROC_FILE}\" | ||
EOF | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is usage even callable when you want to know how to use it? I presume this is based in our previous conversation about scripts that may likely runt without arguments perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, it sure is! good spotting, what do you recommend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me a while to review this today and not yesterday. Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had a chance to dig into these files, but two things caught my eye that I commented on. If you're ready to merge this PR, please don't wait for me.
|
||
For which capabilities can we write XSpec or meaningfully test and confirm (expose and document) in other ways, including | ||
|
||
- `xsl:message` behavior including terminate="yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you're not already aware of it, XSpec can test terminating messages
https://github.com/xspec/xspec/wiki/Testing-Dynamic-Errors
I don't know a way to make XSpec test non-terminating xsl:message
instructions, though. That's why I gave the xslt3-functions message handler an option to emit a processing instruction instead of xsl:message
. The idea is to use the message in production and the PI (a "mock" message) when testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suggests that one step toward testing those requirements would be to use xslt3-functions message handling for all the messages. That is an awesome idea and not out of line with other plans or concepts.
For which capabilities can we write XSpec or meaningfully test and confirm (expose and document) in other ways, including | ||
|
||
- `xsl:message` behavior including terminate="yes" | ||
- side effects such as `xsl:result-document`? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably already know that external transformations can handle XSLT that includes xsl:result-document
. Beyond just not erroring out, I guess a test scenario can check availability of, or read the contents of, the file you expect to have been created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know that but it makes sense, thanks @galtm, very helpful indeed.
Committer Notes
Addresses #101
All Submissions:
Changes to Core Features: