Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch validation of computer samples against their XSD #102
Batch validation of computer samples against their XSD #102
Changes from 2 commits
1ff2286
8d7530a
ad14635
dd65ac0
dbb6481
d6b176f
772f575
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is usage even callable when you want to know how to use it? I presume this is based in our previous conversation about scripts that may likely runt without arguments perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, it sure is! good spotting, what do you recommend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you're not already aware of it, XSpec can test terminating messages
https://github.com/xspec/xspec/wiki/Testing-Dynamic-Errors
I don't know a way to make XSpec test non-terminating
xsl:message
instructions, though. That's why I gave the xslt3-functions message handler an option to emit a processing instruction instead ofxsl:message
. The idea is to use the message in production and the PI (a "mock" message) when testing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suggests that one step toward testing those requirements would be to use xslt3-functions message handling for all the messages. That is an awesome idea and not out of line with other plans or concepts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably already know that external transformations can handle XSLT that includes
xsl:result-document
. Beyond just not erroring out, I guess a test scenario can check availability of, or read the contents of, the file you expect to have been created.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know that but it makes sense, thanks @galtm, very helpful indeed.