Feature/Cmake Install Optimization #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@vrcomputing This is a response to your review on #351, FYI. |
1 task
…package_config_file for optional cmake keyword
lgtmak
force-pushed
the
feature/cmake_install_fixes
branch
from
8c23b72 to
3f74057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accomplishes the following from review on #351
Outstanding issues:
QmlExportheaders are installed - https://github.com/uwerat/qskinny/pull/351/files/f4315ce4acb3da64e6786a39830b52566aa94201#r1444773948QSK_QT_VERSIONvariable - https://github.com/uwerat/qskinny/pull/351/files/f4315ce4acb3da64e6786a39830b52566aa94201#r1438901244_QSkinnyCmake build folder needed?