Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): ShaderInputs ignore props with disableWarnings (9.1) #2314

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(engine): ShaderInputs ignore props with disableWarnings (9.1) #2314

merged 1 commit into from
Jan 9, 2025

Conversation

felixpalmer
Copy link
Collaborator

Fix issue introduced by #2301

Change List

  • Reinstate old behavior, when hiding the warning we still need to continue otherwise we crash

@felixpalmer felixpalmer changed the title fix(engine): ShaderInputs ignore props with disableWarnings fix(engine): ShaderInputs ignore props with disableWarnings (9.1) Jan 9, 2025
@felixpalmer felixpalmer requested a review from ibgreen January 9, 2025 09:31
@felixpalmer felixpalmer merged commit 65d5e14 into 9.1-release Jan 9, 2025
1 check passed
@felixpalmer felixpalmer deleted the felix/shaderinputs-warn-continue branch January 9, 2025 09:38
felixpalmer added a commit that referenced this pull request Jan 9, 2025
@felixpalmer
fix(engine): ShaderInputs ignore props with disableWarnings (#2314)
84ea652
@felixpalmer felixpalmer mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@felixpalmer