Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master (v2.6.0-beta) into develop #264

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2024

Merge master (v2.6.0-beta) into develop

EmilyZhang777 and others added 4 commits January 29, 2024 12:06
This PR addresses the following vulnerabilities:
- api key being exposed
- insecure document methods
- webpack version
### Fixes
- Makes sure images served from EU are properly handled (#1163)
J=CLIP-1226
TEST=auto,manual

Co-authored-by: Yen Truong <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9453388536

Details

  • 18 of 20 (90.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 88.937%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/SearchCore.ts 0 1 0.0%
src/infra/GenerativeDirectAnswerServiceImpl.ts 15 16 93.75%
Totals Coverage Status
Change from base Build 8469143208: -0.4%
Covered Lines: 236
Relevant Lines: 258

💛 - Coveralls

@anguyen-yext2 anguyen-yext2 merged commit d7c4b92 into develop Jun 10, 2024
11 of 12 checks passed
Fondryext pushed a commit that referenced this pull request Dec 9, 2024
Add generativeDirectAnswer service (#263)

J=CLIP-1226
TEST=auto,manual

Co-authored-by: Yen Truong <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@Fondryext Fondryext deleted the dev/merge-v2.6.0-beta-e2fe1fd-into-develop branch December 10, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants