[DBZ-PGYB][yugabyte/yugabyte-db#23153] Change default plugin to yboutput #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about the connector unit tests ? Have they been run ? |
| @@ -540,15 +540,14 @@ public static SchemaRefreshMode parse(String value) { | |||
| public static final Field PLUGIN_NAME = Field.create("plugin.name") | |||
| .withDisplayName("Plugin") | |||
| .withGroup(Field.createGroupEntry(Field.Group.CONNECTION_ADVANCED_REPLICATION, 0)) | |||
| .withEnum(LogicalDecoder.class, LogicalDecoder.DECODERBUFS) | |||
| .withEnum(LogicalDecoder.class, LogicalDecoder.YBOUTPUT) | |||
There was a problem hiding this comment.
Shouldn't this change be made in a Yugabyte specific connector config class ? Similar to the approach for the hostname config ?
There was a problem hiding this comment.
I think this should be fine, we just had to change the default value in the defined field.
For the hostname config, we had to override and already existing field but since this plugin name field is only PostgresConnector specific, there's no other place we can change the default value.
asrinivasanyb
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default plugin in the connector to
yboutput.This closes yugabyte/yugabyte-db#23153