Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBZ-PGYB][yugabyte/yugabyte-db#23153] Change default plugin to yboutput #140

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[DBZ-PGYB][yugabyte/yugabyte-db#23153] Change default plugin to yboutput #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...ctor-postgres/src/main/java/io/debezium/connector/postgresql/PostgresConnectorConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,15 +540,14 @@ public static SchemaRefreshMode parse(String value) {
public static final Field PLUGIN_NAME = Field.create("plugin.name")
.withDisplayName("Plugin")
.withGroup(Field.createGroupEntry(Field.Group.CONNECTION_ADVANCED_REPLICATION, 0))
.withEnum(LogicalDecoder.class, LogicalDecoder.DECODERBUFS)
.withEnum(LogicalDecoder.class, LogicalDecoder.YBOUTPUT)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this change be made in a Yugabyte specific connector config class ? Similar to the approach for the hostname config ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine, we just had to change the default value in the defined field.

For the hostname config, we had to override and already existing field but since this plugin name field is only PostgresConnector specific, there's no other place we can change the default value.

.withWidth(Width.MEDIUM)
.withImportance(Importance.MEDIUM)
.withDescription("The name of the Postgres logical decoding plugin installed on the server. " +
"Supported values are '" + LogicalDecoder.DECODERBUFS.getValue()
+ "' and '" + LogicalDecoder.PGOUTPUT.getValue()
"Supported values are '" + LogicalDecoder.PGOUTPUT.getValue()
+ "' and '" + LogicalDecoder.YBOUTPUT.getValue()
+ "'. " +
"Defaults to '" + LogicalDecoder.DECODERBUFS.getValue() + "'.");
"Defaults to '" + LogicalDecoder.YBOUTPUT.getValue() + "'.");

public static final Field SLOT_NAME = Field.create("slot.name")
.withDisplayName("Slot")
Expand Down