Enhanced the pg_read_all_stats missing grant message #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shubham-yb
requested review from
sanyamsinghal,
priyanshi-yb,
makalaaneesh and
hbhanawat
and removed request for
priyanshi-yb
| @@ -1208,7 +1208,7 @@ func (pg *PostgreSQL) checkPgStatStatementsSetup() (string, error) { | |||
| } | |||
|
|
|||
| if !hasReadAllStats { | |||
| return "User doesn't have permissions to read pg_stat_statements view, required for detecting Unsupported Query Constructs", nil | |||
| return "\n" + color.RedString("Missing Permission:") + " User doesn't have the `pg_read_all_stats` grant, required for detecting Unsupported Query Constructs", nil | |||
There was a problem hiding this comment.
Can you post a screenshot of the overall output on CLI? Also when combined with other missing permissions?
sanyamsinghal
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Fixes: #2056
Describe if there are any user-facing changes
Changed a user facing message to be more specific
Screenshot:
How was this pull request tested?
Manual verification
Does your PR have changes that can cause upgrade issues?