Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced the pg_read_all_stats missing grant message #2063

Merged
merged 1 commit into from
Dec 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion yb-voyager/src/srcdb/postgres.go
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ func (pg *PostgreSQL) checkPgStatStatementsSetup() (string, error) {
}

if !hasReadAllStats {
return "User doesn't have permissions to read pg_stat_statements view, required for detecting Unsupported Query Constructs", nil
return "\n" + color.RedString("Missing Permission:") + " User doesn't have the `pg_read_all_stats` grant, required for detecting Unsupported Query Constructs", nil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post a screenshot of the overall output on CLI? Also when combined with other missing permissions?

}

// To access "shared_preload_libraries" must be superuser or a member of pg_read_all_settings
Expand Down