Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DB-14827] Bug Fix: Migration Complexity Explanation empty in case of Oracle #2171

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

sanyamsinghal
Copy link
Collaborator

Describe the changes in this pull request

  • updated html template to check for empty value

Describe if there are any user-facing changes

Only html report will change in oracle for this section.
There is no section for explanation as you can see below
image

How was this pull request tested?

Manually

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB Yes/No
Name registry json Yes/No
Data File Descriptor Json Yes/No
Export Snapshot Status Json Yes/No
Import Data State Yes/No
Export Status Json Yes/No
Data .sql files of tables Yes/No
Export and import data queue Yes/No
Schema Dump Yes/No
AssessmentDB Yes/No
Sizing DB Yes/No
Migration Assessment Report Json Yes/No
Callhome Json Yes/No
YugabyteD Tables Yes/No
TargetDB Metadata Tables Yes/No

… Oracle

- updated html template to check for empty value
@sanyamsinghal sanyamsinghal self-assigned this Jan 14, 2025
@sanyamsinghal sanyamsinghal requested review from makalaaneesh and priyanshi-yb and removed request for makalaaneesh January 14, 2025 17:13
@sanyamsinghal sanyamsinghal marked this pull request as ready for review January 14, 2025 17:13
Copy link
Collaborator

@makalaaneesh makalaaneesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanyamsinghal sanyamsinghal merged commit e44dc10 into main Jan 17, 2025
67 of 69 checks passed
@sanyamsinghal sanyamsinghal deleted the sanyam/oracle-report branch January 17, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants