-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/4] public library: Implement HTTP connection #278
Conversation
05a7793
to
98e1c60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! To be honest I only have two major concerns before merging:
- The version file, as explained on a comment.
- This PR includes two commit, yours and mine. We can squash them as mine was meant more of a WIP thingie. Hence, before merging, let us squash it with your commit message instead.
d616018
to
fd80c1c
Compare
Introduce several interfaces which allow a caller to perform API requests against an SCC-like API. This includes: * Common options for the connection * Credentials handling * Building and performing requests * Automatically handle system token rotations Reviewed-by: Parag Jain <[email protected]> Signed-off-by: Felix Schnizlein <[email protected]> Signed-off-by: Miquel Sabaté Solà <[email protected]>
fd80c1c
to
3fb6984
Compare
@felixsch @paragjain0910 updated the PR with all the suggestions. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
I'm still not sold on the collectors.Result
topic but lets discuss in the next PR
Yes, let's see it on the next PRs and check what makes sense. |
related card: https://trello.com/c/uRZTaz4g/3682-rr1-library-implement-announce-activate-de-activate-and-de-register
This is the public library implementation which is required to allow Rancher Manager to register against SCC.
The general idea is to easily allow products to register themself to SCC and therefore show up as activated product in the systems details.
In this merge request:
public-api-test
binary to act as demo toolAbout the pull requests
There are multiple merge requests which all together implement a useful subset of the overall API functionality of SCC.
[1/4] public library: Implement HTTP connection
[2/4] public library: Implement registration and status/keepalive
[3/4] public library: Implement product activation and extension traversal
[4/4] public library: repository cleanup
I you are here to review these, please start with the first one (this one) and only start with the next merge request when this one is merged. I will update bases accordingly then. Each merge request enhances the
public-api-test
binary to show demo usage of the implemented functionality in this merge request.If you want to see a full CI run of this set checkout: #281
How to review this merge request (and all others):
public-api-test
application including a demo showing the implementation workingIf you have any questions, need help setting up development environment, do not hesitate to reach out to me 🚀
Thank you! ❤️