-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2/4] public library: Implement registration and status/keepalive #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixsch
force-pushed
the
connect-public-library-registration
branch
from
January 2, 2025 14:55
2e9f283
to
a6f08bb
Compare
This was referenced Jan 2, 2025
felixsch
commented
Jan 2, 2025
felixsch
commented
Jan 2, 2025
felixsch
commented
Jan 2, 2025
mssola
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
mssola
force-pushed
the
connect-public-library
branch
3 times, most recently
from
January 9, 2025 11:41
fd80c1c
to
3fb6984
Compare
The registration creates a new system in SCC and allows for performing the status/keepalive call to update the provided systemInformation. Note: Instead of historically named hwinfo, here everything is named systemInformation
felixsch
force-pushed
the
connect-public-library-registration
branch
from
January 15, 2025 10:25
a6f08bb
to
8568ade
Compare
felixsch
force-pushed
the
connect-public-library-registration
branch
from
January 15, 2025 12:57
9fb0fba
to
242011d
Compare
mssola
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related card: https://trello.com/c/uRZTaz4g/3682-rr1-library-implement-announce-activate-de-activate-and-de-register
This is the public library implementation which is required to allow Rancher Manager to register against SCC.
The general idea is to easily allow products to register themself to SCC and therefore show up as activated product in the systems details.
In this merge request:
About the pull requests
There are multiple merge requests which all together implement a useful subset of the overall API functionality of SCC.
[1/4] public library: Implement HTTP connection
[2/4] public library: Implement registration and status/keepalive
[3/4] public library: Implement product activation and extension traversal
[4/4] public library: repository cleanup
I you are here to review these, please start with the first one (this one) and only start with the next merge request when this one is merged. I will update bases accordingly then. Each merge request enhances the
public-api-test
binary to show demo usage of the implemented functionality in this merge request.If you want to see a full CI run of this set checkout: #281
How to review this merge request (and all others):
public-api-test
application including a demo showing the implementation workingIf you have any questions, need help setting up development environment, do not hesitate to reach out to me 🚀
Thank you! ❤️