Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4/4] public library: repository cleanup #281

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

felixsch
Copy link
Contributor

@felixsch felixsch commented Jan 2, 2025

related card: https://trello.com/c/uRZTaz4g/3682-rr1-library-implement-announce-activate-de-activate-and-de-register

This is the public library implementation which is required to allow Rancher Manager to register against SCC.
The general idea is to easily allow products to register themself to SCC and therefore show up as activated product in the systems details.

In this merge request:

  • Add .mise.toml to gitignore
  • Make github actions run on any branch (within the repositories, not forks)
  • Rename public-api-test to public-api-demo

About the pull requests

There are multiple merge requests which all together implement a useful subset of the overall API functionality of SCC.
[1/4] public library: Implement HTTP connection
[2/4] public library: Implement registration and status/keepalive
[3/4] public library: Implement product activation and extension traversal
[4/4] public library: repository cleanup

I you are here to review these, please start with the first one (this one) and only start with the next merge request when this one is merged. I will update bases accordingly then. Each merge request enhances the public-api-test binary to show demo usage of the implemented functionality in this merge request.

If you want to see a full CI run of this set checkout: #281

How to review this merge request (and all others):

  • Run the public-api-demo application including a demo showing the implementation working
$ make build
$ REGCODE=<regcode> ./out/public-api-demo SLES 15.5 x86_64
  • Check if you can spot inconsistencies regarding the implementation. Any areas of improvements?

If you have any questions, need help setting up development environment, do not hesitate to reach out to me 🚀

Thank you! ❤️

@felixsch felixsch force-pushed the connect-public-library-activation branch from 4c38f0e to fcc1ec6 Compare January 15, 2025 15:03
Base automatically changed from connect-public-library-activation to main January 15, 2025 15:41
@felixsch felixsch force-pushed the connect-public-library-cleanup branch from 6534fd5 to d139a8b Compare January 15, 2025 15:44
@felixsch felixsch merged commit d0b4d07 into main Jan 15, 2025
2 checks passed
@felixsch felixsch deleted the connect-public-library-cleanup branch January 15, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants